Remove NotImplementedError for parse_dates keyword in read_excel #14326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Sep 30, 2016
|
|
||
| read_excel('path_to_file.xls', 'Sheet1', parse_dates=['date_strings']) | ||
|
|
||
| So this should *not* be used when the column in excel has already a datetime-like |
There was a problem hiding this comment.
small nit. I would the last part to the first paragraph you added.
somethings like. normally dates are automatically parsed. But if you have a column of 'strings' that look-like dates, you can use the parse_dates kw.
There was a problem hiding this comment.
yep, adapted a bit
|
lgtm. |
c5e7436 to
656ec44
Compare
|
Apparently it does not work out of the box anymore by re-enabling it (probably due to changes in |
|
@jorisvandenbossche let's update and get this in. |
|
@jorisvandenbossche can you update |
|
@jorisvandenbossche can you rebase |
jreback
pushed a commit
to jreback/pandas
that referenced
this pull request
Mar 27, 2017
Rebase and update of PR pandas-dev#12051 Author: Joris Van den Bossche <[email protected]> Author: Graham R. Jeffries <[email protected]> This patch had conflicts when merged, resolved by Committer: Jeff Reback <[email protected]> Closes pandas-dev#14326 from jorisvandenbossche/pr/12051 and squashes the following commits: 0b65a7a [Joris Van den Bossche] update wording 656ec44 [Joris Van den Bossche] Fix detection to raise warning b1c7f87 [Joris Van den Bossche] add whatsnew 925ce1b [Joris Van den Bossche] Update tests 0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation pandas-dev#11544
jreback
pushed a commit
that referenced
this pull request
Mar 27, 2017
Rebase and update of PR #12051 Author: Joris Van den Bossche <[email protected]> Author: Graham R. Jeffries <[email protected]> This patch had conflicts when merged, resolved by Committer: Jeff Reback <[email protected]> Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits: 0b65a7a [Joris Van den Bossche] update wording 656ec44 [Joris Van den Bossche] Fix detection to raise warning b1c7f87 [Joris Van den Bossche] add whatsnew 925ce1b [Joris Van den Bossche] Update tests 0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
jreback
pushed a commit
that referenced
this pull request
Mar 27, 2017
Rebase and update of PR #12051 Author: Joris Van den Bossche <[email protected]> Author: Graham R. Jeffries <[email protected]> This patch had conflicts when merged, resolved by Committer: Jeff Reback <[email protected]> Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits: 0b65a7a [Joris Van den Bossche] update wording 656ec44 [Joris Van den Bossche] Fix detection to raise warning b1c7f87 [Joris Van den Bossche] add whatsnew 925ce1b [Joris Van den Bossche] Update tests 0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
Rebase and update of PR pandas-dev#12051 Author: Joris Van den Bossche <[email protected]> Author: Graham R. Jeffries <[email protected]> This patch had conflicts when merged, resolved by Committer: Jeff Reback <[email protected]> Closes pandas-dev#14326 from jorisvandenbossche/pr/12051 and squashes the following commits: 0b65a7a [Joris Van den Bossche] update wording 656ec44 [Joris Van den Bossche] Fix detection to raise warning b1c7f87 [Joris Van den Bossche] add whatsnew 925ce1b [Joris Van den Bossche] Update tests 0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation pandas-dev#11544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase and update of PR #12051