ENH: Series.append now has ignore_index kw #13677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.38%@@ master #13677 diff @@
==========================================
Files 142 142
Lines 51223 51223
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43224 43224
Misses 7999 7999
Partials 0 0
|
| @@ -39,6 +39,21 @@ def test_append_many(self): | |||
| result = pieces[0].append(pieces[1:]) | |||
| assert_series_equal(result, self.ts) | |||
|
|
|||
| def test_append_duplicates(self): | |||
| s1 = pd.Series([1, 2, 3]) | |||
| s2 = pd.Series([4, 5, 6]) | |||
There was a problem hiding this comment.
can you add a simultaneous example with pd.concat (same results)
|
lgtm. just minor test comment. |
|
updated test, and now green. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffnot sure if there is any reason we haven't supported...