Check for openpyxl #1007
Closed
Check for openpyxl #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e saved from test.xls. Beautified ugly break of DRY principle in ExcelFile.parse
| "You can install it via 'easy_install openpyxl' or 'pip openpyxl'.\n" | ||
| "Alternatively, you could save the .xlsx file as a .xls file.\n" | ||
| "Parsed nothing for now.\n") | ||
| return |
There was a problem hiding this comment.
I was not sure how to get out of the Exception Handling? Let me know if you desire something else.
There was a problem hiding this comment.
I don't think returning None is appropriate in this case; an exception should be raised (with the more helpful error message)
There was a problem hiding this comment.
I agree, fixed that. How cool that github automatically adds that commit to this pull request! I guess pull requests are related to the branch, so when I change the branch it will be included in the pull request? (I am still new to githubbing.. ;)
|
thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a try/except catch for the lack of an installed openpyxl. The user gets a nice message that she needs to install it or to save the .xlsx file as .xls.
I also added a test for it and a test.xlsx file that I saved from test.xls.
Furthermore I noticed an ugly break of the DRY principle in ExcelFile.parse and gave an alternative with a nice dictionary that provides the handle for the required method depending on the 'use_xlsx' flag.