Skip to content

remove 1.5 tests and types #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023
Merged

remove 1.5 tests and types #626

merged 2 commits into from
Apr 4, 2023

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Apr 4, 2023

Tested with pandas 2.0. Removed references to pandas 1.5, and removed types (NumericIndex related), creating special types for typing so we can track Index with int and Index with float

Updated the version number, but don't intend to do a release until we handle issues in #624

@Dr-Irv Dr-Irv requested a review from twoertwein April 4, 2023 01:46
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I wouldn't mind removing the typing-only classes (less perceive typing but more maintanable).

@twoertwein twoertwein merged commit 9c301b3 into pandas-dev:main Apr 4, 2023
@twoertwein
Copy link
Member

Thanks @Dr-Irv !

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Apr 4, 2023

Personally, I wouldn't mind removing the typing-only classes (less perceive typing but more maintanable).

I started doing that. But we have methods that in 1.5 were dependent on Int64Index and Float64Index. If I switch to Index, then it creates all sorts of overload problems.

This is one of these cases where removing NumericIndex and its subclasses was not good from a typing perspective.

The _IntIndexType and _FloatIndexType classes are a step towards a generic index implementation, similar to how we have TimeStampSeries, TimeDeltaSeries, etc.

@Dr-Irv Dr-Irv deleted the remove15 branch December 2, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants