Documents operator-lib PR #100. #5515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like you forgot to sign your commit |
Done |
| if x.GVK.Kind == PodKind { | ||
| req := cfg.Clientset.CoreV1().Pods(x.Namespace).GetLogs(x.Name, &v1.PodLogOptions{}) | ||
| func myhook(cfg Config, res ResourceInfo) error { | ||
| log.V(4).Info("pre-deletion", "GVK", res.GVK, "namespace", res.Namespace, "name", res.Name) |
There was a problem hiding this comment.
should we not update here to use the log from the context either
@fgiloux ?
There was a problem hiding this comment.
@camilamacedo86 as soon as the code fix has been merged I will update this doc PR. There are a couple of places that would need to be changed to align to the current version of the code fix and this is one of them.
log could not be set as it was unexported. Signed-off-by: Frederic Giloux <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
Doc updated to align with the modifications of the code PR |
|
I think it address all comments/suggestions made so far |
prary
pushed a commit
to prary/operator-sdk
that referenced
this pull request
Apr 2, 2022
…#5515) log could not be set as it was unexported. Signed-off-by: Frederic Giloux <[email protected]> Signed-off-by: Prashant Arya <[email protected]>
prary
pushed a commit
to prary/operator-sdk
that referenced
this pull request
Apr 2, 2022
…#5515) log could not be set as it was unexported. Signed-off-by: Frederic Giloux <[email protected]> Signed-off-by: Prashant Arya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
The log field could not be set as it was unexported. The log strategy also needed to be aligned with the rest of the library.
operator-lib PR #100
Motivation for the change:
It was not usable as it was and the documentation needs to reflect the implementation change
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs