Skip to content

✨ Add label selectors to CE API for catalog selection #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 16, 2024

Fixes #1111

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner August 16, 2024 20:18
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 414a96a
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66c381050294ed000831c006
😎 Deploy Preview https://deploy-preview-1137--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort tmshort changed the title ✨ Add label selectors for catalog selection ✨ Add label selectors to CE API for catalog selection Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.80%. Comparing base (94ae951) to head (414a96a).
Report is 1 commits behind head on main.

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (94ae951) and HEAD (414a96a). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (94ae951) HEAD (414a96a)
unit 2 1
e2e 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1137       +/-   ##
===========================================
- Coverage   75.44%   50.80%   -24.64%     
===========================================
  Files          35       35               
  Lines        1918     1919        +1     
===========================================
- Hits         1447      975      -472     
- Misses        329      869      +540     
+ Partials      142       75       -67     
Flag Coverage Δ
e2e 0.00% <0.00%> (-58.19%) ⬇️
unit 50.80% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort tmshort force-pushed the labels branch 2 times, most recently from 0c6a636 to 29e8145 Compare August 19, 2024 13:51
@tmshort
Copy link
Contributor Author

tmshort commented Aug 19, 2024

go-apidiff is expected to error out with a new API change.

Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@tmshort
Copy link
Contributor Author

tmshort commented Aug 19, 2024

Not sure why tilt is failing, seems to be a failure of the manager to come up?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
Copy link

openshift-ci bot commented Aug 19, 2024

New changes are detected. LGTM label has been removed.

@tmshort
Copy link
Contributor Author

tmshort commented Aug 19, 2024

(Rebased to main)

@tmshort
Copy link
Contributor Author

tmshort commented Aug 19, 2024

Tilt is broken until this repo is updated with the latest catalogd

@tmshort tmshort added this pull request to the merge queue Aug 19, 2024
Merged via the queue into operator-framework:main with commit 13efcd0 Aug 19, 2024
14 of 18 checks passed
@tmshort tmshort deleted the labels branch August 19, 2024 19:01
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the ClusterExtension API to include label selectors and update status
4 participants