Skip to content

ClusterCatalog label policy enforcement + test - catalogd #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1028
tmshort opened this issue Aug 12, 2024 · 1 comment
Closed
Tracked by #1028

ClusterCatalog label policy enforcement + test - catalogd #1114

tmshort opened this issue Aug 12, 2024 · 1 comment
Assignees
Labels
epic/catalog-selection v1.0 Issues related to the initial stable release of OLMv1
Milestone

Comments

@tmshort
Copy link
Contributor

tmshort commented Aug 12, 2024

Possibly as a validating webhook that runs after the mutating webhook enforce labeling policy.

Policy enforcement includes, but maybe is not limited to:
Each catalog name label is uniquely named.

@everettraven everettraven added this to the v1.0.0 milestone Aug 20, 2024
@tmshort tmshort added this to OLM v1 Aug 27, 2024
@tmshort tmshort moved this to Accepted in OLM v1 Aug 27, 2024
@everettraven everettraven added the v1.0 Issues related to the initial stable release of OLMv1 label Aug 27, 2024
@tmshort tmshort moved this to Accepted in OLM v1 Aug 30, 2024
@bentito
Copy link
Contributor

bentito commented Sep 5, 2024

This isn't needed. The mutating webhook #1113 takes care of always making the label name equal to the ClusterCatalog name. This validation was potentially to check if there were duplicates if we allowed users to select the value of the label, which we don’t do.

@bentito bentito closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
@tmshort tmshort moved this from Accepted to Defunct in OLM v1 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/catalog-selection v1.0 Issues related to the initial stable release of OLMv1
Projects
Archived in project
Development

No branches or pull requests

3 participants