Skip to content

[Feature Request] Add type to result of condition evaluation #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
btlem opened this issue Jun 3, 2024 · 3 comments · Fixed by #2426
Closed

[Feature Request] Add type to result of condition evaluation #2424

btlem opened this issue Jun 3, 2024 · 3 comments · Fixed by #2426
Assignees
Milestone

Comments

@btlem
Copy link

btlem commented Jun 3, 2024

Summary

The current Workflow implementation allows for the registration of dependent ready conditions, which produces a binary result. However, the specific business logic for what "ready" means may contain information that would be useful to propagate to the status of the primary, such as "Conditions".

Proposal (for brainstorming)

Include an additional return type in the signature of the isMet method, which will allow for storing additional information related to the computation of whether the dependent is ready or not.

Example Scenario

Dependent Resource -> Ingress
Is Ready Condition -> Are endpoints externally accessible (DNS record etc), returns status of each
Primary Status Condition -> Are endpoints ready, if not which are pending

@csviri
Copy link
Collaborator

csviri commented Jun 4, 2024

This sounds, useful yes!

Note that you can now add arbitrary information to the context and use it later when creating the status here:

<T> Optional<T> get(Object key, Class<T> expectedType);
/**
* Associates the specified contextual value to the specified key. If the value is {@code null},
* the semantics of this operation is defined as removing the mapping associated with the
* specified key.
*
* @param <T> object type
* @param key the key identifying which contextual object to add or remove from the context
* @param value the value to add to the context or {@code null} to remove an existing entry
* associated with the specified key
* @return an Optional containing the previous value associated with the key or
* {@link Optional#empty()} if none existed
*/
@SuppressWarnings("unchecked")
<T> T put(Object key, T value);

@csviri csviri added this to the 5.0 milestone Jun 4, 2024
@metacosm metacosm self-assigned this Jun 5, 2024
metacosm added a commit that referenced this issue Jun 5, 2024
Fixes #2424. Currently, only exposed for ready post conditions but is
supported for all conditions if needed.

Signed-off-by: Chris Laprun <[email protected]>
@metacosm
Copy link
Collaborator

metacosm commented Jun 5, 2024

@btlem let us know if the associated PR addresses your use case.

@csviri csviri linked a pull request Jun 6, 2024 that will close this issue
@btlem
Copy link
Author

btlem commented Jun 11, 2024

@metacosm Read through the PR and it looks good to me. I agree with the comment that it is general and could be applied to more conditions, though my main use-case is covered here, so this part is mainly nice-to-have for me

Thanks both (+ @csviri ) for the quick action on this!

csviri pushed a commit that referenced this issue Jun 18, 2024
Fixes #2424. Currently, only exposed for ready post conditions but is
supported for all conditions if needed.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Jun 19, 2024
Fixes #2424. Currently, only exposed for ready post conditions but is
supported for all conditions if needed.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Jun 20, 2024
Fixes #2424. Currently, only exposed for ready post conditions but is
supported for all conditions if needed.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Jul 1, 2024
Fixes #2424. Currently, only exposed for ready post conditions but is
supported for all conditions if needed.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Jul 2, 2024
Fixes #2424. Currently, only exposed for ready post conditions but is
supported for all conditions if needed.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Jul 8, 2024
Fixes #2424. Currently, only exposed for ready post conditions but is
supported for all conditions if needed.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Jul 8, 2024
Fixes #2424. Currently, only exposed for ready post conditions but is
supported for all conditions if needed.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Jul 8, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Jul 9, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Jul 12, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this issue Aug 8, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Aug 8, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Aug 9, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
@csviri csviri closed this as completed Aug 9, 2024
metacosm added a commit that referenced this issue Aug 9, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this issue Aug 15, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this issue Aug 15, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Aug 16, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Aug 29, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Aug 29, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this issue Sep 20, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this issue Sep 20, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Oct 10, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Oct 10, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 5, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 5, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 6, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 6, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this issue Nov 13, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this issue Nov 13, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 19, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 19, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 20, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 20, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 27, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Nov 27, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this issue Dec 6, 2024
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this issue Dec 6, 2024
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <[email protected]>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <[email protected]>

* fix: format after rebase

Signed-off-by: Attila Mészáros <[email protected]>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <[email protected]>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <[email protected]>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <[email protected]>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants