-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: New deployment controller #247
base: master
Are you sure you want to change the base?
DRAFT: New deployment controller #247
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
preconditions []func(context.Context) (bool, error) | ||
} | ||
|
||
func NewMyController( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure if this meets the goal of writing new controller with DeploymentController API
- ideally the API of the new controller should match the current deployment controller (so for callers the change is transparent) but I was not sure how that could be done since the signature of workload controller constructor is different.
Related bug: https://issues.redhat.com/browse/OCPBUGS-24588
ClusterCSIDriver condition when precondition fails:
Controllers can be configured with csi-operator to have multiple preconditions, errors are then aggregated in ClusterCSIDriver: