Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to remove lint as there is no support from catalog-cd tool #33

Merged

Conversation

savitaashture
Copy link
Member

Update the workflow as there is no lint command available in catalog-cd tool

@openshift-ci openshift-ci bot requested review from concaf and vdemeester April 2, 2024 07:13
@savitaashture savitaashture requested review from Aneesh-M-Bhat and Senjuti256 and removed request for vdemeester and concaf April 2, 2024 07:13
Comment on lines 29 to 33
git clone https://github.com/tektoncd/catlin
cd catlin
make bin/catlin
sudo cp bin/catlin /usr/local/bin
catlin --help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the portion of linting using Catlin? @savitaashture

Copy link
Member Author

@savitaashture savitaashture Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question!!

I did check for all the repos and i don't see anywhere we are doing linting using catalin (Not sure the reason) as well i remember @vdemeester saying that something related to catlin tool

So just removed from Openshift as well and thought to bring this point in the ecosystem discussion call to have a consistent linting across all the repos for yamls

Copy link
Contributor

@Senjuti256 Senjuti256 Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but I remember @vdemeester told that we require to run some form of linting on the results of the helm template and we used Catlin as it was upstream. This linting was added because there was a JIRA issue that required that our tasks (or the tasks in ecosystem catalog) should contain Red Hat supported images only and we decided to ensure this by making some changes to the portion of linting only. @savitaashture

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think @vdemeester can provide a better context to this than me@savitaashture

Copy link
Member Author

@savitaashture savitaashture Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senjuti256

I removed only catalog-cd tool part as there is no lint and kept catalin lint as it is
Verified linting execution here https://github.com/savitaashture/task-openshift/actions/runs/8564598061/job/23471378385

Comment on lines 36 to 45
# run Catlin linting
- name: Run Catlin linting
run: |
set -Eeu
helm template task-oc . > task-oc.yaml
cat task-oc.yaml
catlin validate task-oc.yaml || true
helm template task-tkn . > task-tkn.yaml
cat task-tkn.yaml
catlin validate task-tkn.yaml || true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we require any kind of linting for the YAML files? @savitaashture

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same ans as abve

@Aneesh-M-Bhat
Copy link
Contributor

This makes sense to me, the lint job has been failing since Jan end as I see it.
( actually lot of the other tests have also been failing, when i took a look just now, so not sure what's happening with the CI in this repo. )

@savitaashture
Copy link
Member Author

( actually lot of the other tests have also been failing, when i took a look just now, so not sure what's happening with the CI in this repo. )

@Aneesh-M-Bhat The failure of CI on all pushed commit is because we don't have serverless installed for Kind after adding kn-apply & kn task

TaskRun started: kn-apply-run-2cd9s
Waiting for logs to be available...
[kn] Error: services.serving.knative.dev "hello" is forbidden: User "system:serviceaccount:default:default" cannot get resource "services" in API group "serving.knative.dev" in the namespace "default"
[kn] Run 'kn --help' for usage

@savitaashture
Copy link
Member Author

@Aneesh-M-Bhat created issue : #34

Copy link
Contributor

@Senjuti256 Senjuti256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Apr 5, 2024
Copy link

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture, Senjuti256

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 39aaef1 into openshift-pipelines:main Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants