Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to resolve the issue with the linting job. #15

Merged
merged 10 commits into from
Dec 14, 2023
Merged

Trying to resolve the issue with the linting job. #15

merged 10 commits into from
Dec 14, 2023

Conversation

Senjuti256
Copy link
Contributor

@Senjuti256 Senjuti256 closed this Dec 8, 2023
@Senjuti256 Senjuti256 reopened this Dec 8, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 8, 2023

@Senjuti256: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/osp-nightly-ocp-412-e2e 0648c7c link true /test osp-nightly-ocp-412-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Senjuti256 Senjuti256 changed the title Trying out my luck in linting Trying to resolve the issue with the linting job. Dec 12, 2023
vdemeester
vdemeester requested changes Dec 14, 2023
View reviewed changes
.github/workflows/test.yaml
@@ -27,25 +27,30 @@ jobs:
# Install Catlin linting tool
- name: Install linting tools
run: |
set -Eeu
GOBIN=/usr/local/bin/ go install github.com/tektoncd/catlin/cmd/catlin@latest
GOBIN=/usr/local/bin/ go install github.com/openshift-pipelines/tektoncd-catalog/cmd/catalog-cd@latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to run/install catalog-cd though (as it is used later)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved this issue @vdemeester

vdemeester
vdemeester approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try like that 👼🏼

@openshift-ci openshift-ci bot added the lgtm label Dec 14, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Senjuti256, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester vdemeester merged commit 2bddee5 into openshift-pipelines:main Dec 14, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@otaviof otaviof Awaiting requested review from otaviof

Assignees

@vdemeester vdemeester

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Senjuti256 @vdemeester