Skip to content

chore: move cypress out of demo and fix set up #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 5, 2021
Merged

Conversation

tiffafoo
Copy link

@tiffafoo tiffafoo commented Nov 4, 2021

Summary

  • Move cypress out of demo
  • Add ci specific config and dev specific config
  • Fix testing-library types not being found

This PR is the base in which all the tests are written on top of so should be merged first.

Test plan

  1. Visit the Deploy Preview Logs: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6184066e70c9010007ed5ccf#L379
  2. See that cypress runs the testing-library test correctly

  1. Checkout this branch
  2. Run npm run cy:open
  3. In the GUI that pens, run the test
  4. See that it runs the test and everything passes

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal (small picture)

https://github.com/netlify/pod-ecosystem-integrations/issues/33

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Nov 4, 2021
@tiffafoo tiffafoo changed the title chore: move cypress out of demo chore: move cypress out of demo and fix set up Nov 4, 2021
@tiffafoo tiffafoo marked this pull request as ready for review November 4, 2021 16:21
@tiffafoo tiffafoo requested a review from ascorbic November 4, 2021 16:21
@tiffafoo tiffafoo self-assigned this Nov 4, 2021
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@tiffafoo tiffafoo merged commit fa9ca56 into main Nov 5, 2021
@tiffafoo tiffafoo deleted the tln/cypress branch November 5, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants