-
-
Notifications
You must be signed in to change notification settings - Fork 533
fix(openapi-typescript): prevent type error when items is boolean #2260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openapi-typescript): prevent type error when items is boolean #2260
Conversation
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: bbf89d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@kerwanp I'm not sure if I need to add a changeset or not, I only saw a handful currently there so I'm assuming it's either new or not used. Please let me know, happy to add one if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Please just add a patch
changeset (see comment) so we can credit you for this fix, and also push a release after merge.
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
Changes
Prevents a
TypeError
due to a badin
operator fortype: "array"
.Example: https://json-schema.org/understanding-json-schema/reference/array
How to Review
Take it as it is :)
Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)