Skip to content

LC_NUMERIC locale #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2014
Merged

LC_NUMERIC locale #5

merged 1 commit into from
Jul 9, 2014

Conversation

cdunn2001
Copy link
Contributor

non-English locales often use ',' instead of '.' for numbers,
contrary to the JSON standard.

See:

@cdunn2001 cdunn2001 closed this Jul 9, 2014
@cdunn2001 cdunn2001 deleted the locale branch July 9, 2014 05:14
@cdunn2001 cdunn2001 restored the locale branch July 9, 2014 05:15
@cdunn2001 cdunn2001 reopened this Jul 9, 2014
@cdunn2001 cdunn2001 mentioned this pull request Jul 9, 2014
Closed
@steffen-kiess
Copy link

The problem I see with this approach is that the library changes global state, which might cause problems with multithreaded programs.

@steffen-kiess @cdunn2001
Use std::stringstream instead of snprintf() for double->string conver…
eab3096 
…sion

`snprintf()` will use the current `LC_NUMERIC` locale
for converting a double to a string,
which will use a `,` instead of a `.` in some locales (e.g. de_DE).
`std::stringstream` allows setting the locale to `"C"` to always get a `.`.
This occurs only for that `stringstream` instance; no global is
altered.
@cdunn2001 cdunn2001 closed this Jul 9, 2014
@cdunn2001 cdunn2001 deleted the locale branch July 9, 2014 18:34
@cdunn2001
Copy link
Contributor Author

Oops. True. And I misunderstood your solution. I thought you were altering the global too. Your way is not so bad, and the library is not intended for highest efficiency anyway.

Ok. I'll put it back.

This ticket might interest you.

@cdunn2001 cdunn2001 reopened this Jul 9, 2014
@cdunn2001 cdunn2001 merged commit eab3096 into open-source-parsers:master Jul 9, 2014
@cdunn2001
Copy link
Contributor Author

Rebased, but done.

@dodng dodng mentioned this pull request Mar 3, 2017
Closed
@ghost ghost mentioned this pull request May 23, 2017
Closed
@xjtuwjp xjtuwjp mentioned this pull request Sep 28, 2018
Closed
@huangsanm huangsanm mentioned this pull request Sep 2, 2019
Closed
@subithaparamasivan subithaparamasivan mentioned this pull request Oct 30, 2019
Closed
@RambabuTirumalasetty RambabuTirumalasetty mentioned this pull request Nov 7, 2019
Closed
@coolcode-ws coolcode-ws mentioned this pull request Jan 8, 2020
Closed
@bveldhoen bveldhoen mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdunn2001 @steffen-kiess