Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the configuration #218

Closed
marwanm-dev opened this issue Mar 12, 2023 · 5 comments
Closed

Restructure the configuration #218

marwanm-dev opened this issue Mar 12, 2023 · 5 comments

Comments

@marwanm-dev
Copy link

marwanm-dev commented Mar 12, 2023

A 500 line init.lua is not the best especially as plugins and remaps grow.

In need to restructure this repo's 500 line init.lua configuration to be something close to this:
init.lua
remap.lua
set.lua
lazy.nvim.lua
after/plugins
/lspconfig.lua
/treesitterconfig.lua
inspired by ThePrimeagen init.lua neovim setup

I understand the concept of a kickstart init.lua but a pull request by anyone experienced will be enough and shouldn't take much time as I am not an expert in lua.
Thanks.

@mjlbach
Copy link

mjlbach commented Mar 15, 2023

I started kickstart.nvim back when I was an active neovim user. For various reasons not outlined here, I transferred the repo to nvim-lua, made it private, and then TJ made it unprivate again with my blessing.

Originally, the file was 250 lines of code and used as the reference configuration for lspconfig. Since i don't maintain lspconfig anymore, that purpose has drifted.

I do feel like something has been lost, and the repo has grown in size and complexity.

Instead of splitting up the repo to account for this, I would instead advocate for a return to roots and focus on getting the number of lines back down closer to 250 rather than split the config up, at which point why not use astro.nvim, lazyvim, nvchad, lunarvim, etc.

I revisited the config, and trimmed most of what I found to be unnecessary here:
https://github.com/mjlbach/kickstart.nvim/blob/master/init.lua

Probably with a discussion of defaults, lsp-installers, keybinds, and a survey of the features people are actually using we could get it back down to 250 lines.

@mateusabelli
Copy link

Hello, for me personally the selling point to kickstart.nvim has always been the single file setup. I feel like it really emphasize the concept that setting up a basic neovim config should not be hard.

@mjlbach
Copy link

mjlbach commented Mar 18, 2023

I talked about this with TJ a bit. I renamed the original kickstart repo starter.nvim and will be maintaining it as the most minimal possible single file setup, so this repo is free to expand/focus on whatever TJ's vision :)

@marwanm-dev
Copy link
Author

As I said, I know the point of a one file configuration but when the file gets bigger it'll be harder to maintain, so if someone should split up the default one file "kickstart.nvim" into the specified folder structure so anyone could use it and expand on that since I am not an expert.

I tried to move plugins into after/plugins and it kept crashing.

With that said, can some experts join us as contributors at starter.nvim by @mjlbach .

Thanks for your time and effort.

@feoh
Copy link
Collaborator

feoh commented Apr 18, 2023

@mjlbach Thanks so much for creating starter.nvim.

I personally eel like there's a ton of value in having a very minimal starting point like that, but also in having a 'batteries included' solution like kickstart.nvim - especially the version that came out of @tjdevries lazy.nvim rewrite.

Seems like all's well that ends well here. Gonna close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants