-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
MAINT: Add appveyor badge to README #9806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6db8c43
to
46186e2
Compare
With the two badges, might be good to label them. |
I think this might work better:
|
Here are alternatives:
The last one (suggested by @eric-wieser) looks good. But i am not sure how to ensure it is using the master branch (presumably it does by default). It also appeared slow to render sometimes (on my machine), but I don't know if that was a fluke or not as it appears to render fast now. The middle two options take advantage of AppVeyor's support for customizing text. Unfortunately, Travis does not include a logo and does not support customizing the text yet (although there is interest): I slightly prefer the first option (over the last one) as I think most people that would know what Travis and Appveyor are would recognize their default badges. It is fairly common:
And I know how to ensure they are associated with the master branch. However, that isn't a strong preference and am perfectly happy to do whatever you prefer. |
I renamed |
@jarrodmillman AFAICT, appveyor.yml cannot be a hidden file. Google shows a number of requests for that functionality, but I haven't seen anything that shows that it is available. |
@charris It is supported: https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming I believe it is the config file, which is used to run the tests on this PR. Other projects also use it without any problems:
Any preference for which alternative to use for the badges? |
OK. However, I would prefer the rename to be in a separate PR rather than tagged onto a README maintenance PR. |
46186e2
to
c09ce87
Compare
I split the rename into a separate PR (see #9807) as requested. |
c09ce87
to
c63329f
Compare
It turns out we can point the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In future you can use [ci skip]
in the commit message to not trigger builds, since those don't test docs anyway.
Thanks for the note about |
@jarrodmillman Note that if you go to |
Thanks @jarrodmillman . I note that this doesn't render that well on Linux with Firefox, but it looks good on Chrome and Brave. |
You can see a rendered version here: https://github.com/jarrodmillman/numpy/tree/appveyor