Skip to content

MAINT: Add appveyor badge to README #9806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Oct 1, 2017

@charris
Copy link
Member

charris commented Oct 1, 2017

With the two badges, might be good to label them.

@charris charris changed the title Add appveyor badge and hide config MAINT: Add appveyor badge and hide config to README.md Oct 1, 2017
@eric-wieser
Copy link
Member

I think this might work better:


[![Travis](https://img.shields.io/travis/numpy/numpy.svg?label=travis)](https://travis-ci.org/numpy/numpy)
[![AppVeyor](https://img.shields.io/appveyor/ci/charris/numpy.svg?label=appveyor)](https://ci.appveyor.com/project/charris/numpy)

@jarrodmillman
Copy link
Member Author

Here are alternatives:

The last one (suggested by @eric-wieser) looks good. But i am not sure how to ensure it is using the master branch (presumably it does by default). It also appeared slow to render sometimes (on my machine), but I don't know if that was a fluke or not as it appears to render fast now.

The middle two options take advantage of AppVeyor's support for customizing text.

Unfortunately, Travis does not include a logo and does not support customizing the text yet (although there is interest):

I slightly prefer the first option (over the last one) as I think most people that would know what Travis and Appveyor are would recognize their default badges. It is fairly common:

And I know how to ensure they are associated with the master branch.

However, that isn't a strong preference and am perfectly happy to do whatever you prefer.

@jarrodmillman
Copy link
Member Author

I renamed appveyor.yml to .appveyor.yml. I assume that went uncommented as it seems the obvious thing to do (e.g., the travis config is a dot-file). But I just wanted to make sure it was mentioned, since it would be easy to miss.

@charris
Copy link
Member

charris commented Oct 1, 2017

@jarrodmillman AFAICT, appveyor.yml cannot be a hidden file. Google shows a number of requests for that functionality, but I haven't seen anything that shows that it is available.

@jarrodmillman
Copy link
Member Author

@charris It is supported: https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming

I believe it is the config file, which is used to run the tests on this PR. Other projects also use it without any problems:

Any preference for which alternative to use for the badges?

@charris
Copy link
Member

charris commented Oct 1, 2017

OK. However, I would prefer the rename to be in a separate PR rather than tagged onto a README maintenance PR.

@jarrodmillman jarrodmillman changed the title MAINT: Add appveyor badge and hide config to README.md MAINT: Add appveyor badge to README Oct 1, 2017
@jarrodmillman
Copy link
Member Author

I split the rename into a separate PR (see #9807) as requested.

@jarrodmillman
Copy link
Member Author

It turns out we can point the img.shields.io to the master branch, which I've done. Here is what the current PR looks like: https://github.com/jarrodmillman/numpy/blob/appveyor/README.md

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In future you can use [ci skip] in the commit message to not trigger builds, since those don't test docs anyway.

@jarrodmillman
Copy link
Member Author

Thanks for the note about [ci skip]. That is very useful.

@charris
Copy link
Member

charris commented Oct 1, 2017

@jarrodmillman Note that if you go to Files changed and hit the view button you will see the rendered version.

@charris charris merged commit 2cac476 into numpy:master Oct 1, 2017
@charris
Copy link
Member

charris commented Oct 2, 2017

Thanks @jarrodmillman . I note that this doesn't render that well on Linux with Firefox, but it looks good on Chrome and Brave.

@jarrodmillman jarrodmillman deleted the appveyor branch November 4, 2017 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants