Skip to content

BUG: Add __ne__ method to dummy_ctype class. #9609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2017
Merged

BUG: Add __ne__ method to dummy_ctype class. #9609

merged 1 commit into from
Aug 26, 2017

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@charris
Copy link
Member

charris commented Aug 25, 2017

Could you redo the commit message and provide a description? The class is dummy_ctype, not sure what dunder is. Also take a look at doc/source/dev/gitwash/development_workflow.rst to see the correct prefixes for the commit summary line. I think here BUG: is probably correct, as the documentation suggests that both __eq__ and __ne__ should be explicitly defined.

@srinivasreddy
Copy link
Contributor Author

Done. dunder = double underscore 😃

@srinivasreddy srinivasreddy changed the title Add dunder - __ne__ to complete comparisons BUG: Add dunder - __ne__ to complete comparisons Aug 26, 2017
@charris charris changed the title BUG: Add dunder - __ne__ to complete comparisons BUG: Add __ne__ method to dummy_ctype class. Aug 26, 2017
@charris
Copy link
Member

charris commented Aug 26, 2017

Looks good, but the commit message still needs improvement. All lines should be <=72 characters in length, and the summary even shorter if possible. There are plugins for different editors that help with git commit messages. Anyway, something like

BUG: add `__ne__`  method to dummy_ctype class.

There is no Python defined relation between `__eq__` and `__ne__`,  so it is
recommended that both be defined.

@charris charris changed the title BUG: Add __ne__ method to dummy_ctype class. BUG: Add __ne__ method to dummy_ctypes class. Aug 26, 2017
@charris charris changed the title BUG: Add __ne__ method to dummy_ctypes class. BUG: Add __ne__ method to dummy_ctype class. Aug 26, 2017
There is no Python defined relation between `__eq__` and `__ne__`,  so it is
recommended that both be defined.
@charris
Copy link
Member

charris commented Aug 26, 2017

Appveyor error is http timeout, so merging this. Thanks @srinivasreddy .

@charris charris merged commit 5e53775 into numpy:master Aug 26, 2017
@srinivasreddy srinivasreddy deleted the ne_dunder branch August 26, 2017 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants