Skip to content

BUG: Return the poly1d coefficients array directly #9390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jul 8, 2017

Turns out that this was relied upon downstream

We also add a setter for coeffs, so that augmented assignment does not both
change state and raise an exception suggesting state could not be changed.

(see #9385)

Trivial to forward port after merging, since the parent commit is the one that introduced the bug

Turns out that this was relied upon downstream

We also add a setter for coeffs, so that augmented assignment does not both
change state and raise an exception suggesting state could not be changed.
@eric-wieser eric-wieser added this to the 1.13.2 release milestone Jul 8, 2017
@charris charris merged commit 8535cc1 into numpy:maintenance/1.13.x Jul 12, 2017
@charris
Copy link
Member

charris commented Jul 12, 2017

The simplest thing would be to change _coeffs to coeffs and forget the getter and setter. But the class is already weird enough, lip stick on a pig and all that. So might as put this in to fix the issue. Thanks Eric.

@eric-wieser
Copy link
Member Author

I think ._coeffs had to be left for backwards compatibility? Maybe I'm remembering that incorrectly.

But yes, let's not put so much lipstick on this to make users unaware that there's a pig underneath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants