BUG: Fix error in fromstring function from numpy.core.records (#9369) #9372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9369) BUG: fix error in fromstring function from numpy.core.records the shape was computer using true division and ndarray expects a tuple of integers as shape parameter
eric-wieser
reviewed
Jul 6, 2017
| @@ -704,7 +704,7 @@ def fromstring(datastring, dtype=None, shape=None, offset=0, formats=None, | |||
|
|
|||
| itemsize = descr.itemsize | |||
| if (shape is None or shape == 0 or shape == -1): | |||
| shape = (len(datastring) - offset) / itemsize | |||
| shape = (len(datastring) - offset) // itemsize | |||
There was a problem hiding this comment.
Should we be checking here that the remainder is 0 too?
from numpy import dtype
from numpy.core.records import fromstring
data = bytes(list(range(256)))
dtypes = dtype( [('res1', '>u4'), ('t', 'f4')] )
recs = fromstring(data, dtypes)@charris this simple code gives TypeError: 'float' object cannot be interpreted as an integer in numpy 1.13, and in 1.11 it gives a deprecation warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9369.
the shape was computer using true division and
ndarray expects a tuple of integers as shape parameter