Skip to content

ENH: Release the GIL in einsum() special-cased loops #9246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2017

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jun 12, 2017

This does not only allow parallelization but also fixes issues where a background IO loop would suffer long wait times due to a large concurrent einsum() in another thread.

This does not only allow parallelization but also fixes issues where a background
IO loop would suffer long wait times due to a large concurrent einsum() in another
thread.
@charris
Copy link
Member

charris commented Jun 16, 2017

@pitrou Could you add a note to the 1.14.0 release notes under improvements?

@charris
Copy link
Member

charris commented Jun 16, 2017

LGTM. Might look at NPY_BEGIN_THREADS_THRESHOLDED as releasing the GIL for small loops might be counterproductive.

@charris charris added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Jun 16, 2017
@charris charris merged commit b7050a9 into numpy:master Jun 20, 2017
@charris
Copy link
Member

charris commented Jun 20, 2017

Thanks @pitrou .

@charris charris removed the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants