MAINT: Take out code that will never be executed

[k-kapp]

See issue #9154

[mhvk]

This looks right to me -- this code path cannot be reached -- but since @njsmith last touched this part of the file and changed just these 3 lines, maybe good to have his comments; it may have been the intent to solve for something else...

p.s. As noted by @eric-wieser, it is fine to make a PR directly, without raising a separate issue. Indeed, it helps to keep the description of the problem together with its solution!

[charris]

LGTM, thanks @k-kapp

@njsmith Comment?

[charris]

Looks like over zealous cut-n-paste was the culprit.

[njsmith]

Sorry I missed this. The patch looks good to me. My change back in 2012 was just mechanically replacing a manual writeability check with a call to a utility function doing the same thing. The odd 'if (!writeable) { if (writeable) { ... } }' structure is older, and I have no explanation for it :-).

…

On Jun 1, 2017 10:27 AM, "Charles Harris" ***@***.***> wrote: Looks like over zealous cut-n-paste was the culprit. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9155 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAlOaAth4ZhmXY0U3qJ49FDJv8S0Rfhsks5r_vSNgaJpZM4NhvBc> .