Skip to content

TST: fix io test that doesn't close file #8997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2017
Merged

TST: fix io test that doesn't close file #8997

merged 1 commit into from
Apr 26, 2017

Conversation

ahaldane
Copy link
Member

Fix is to test_io_open_buffered_fromfile

Whenever I run tests I have been getting this stuff printed in the middle of the test output:

Exception ignored in: <_io.FileIO name='/tmp/tmp4g2d4y05/tmp0v65u9_2' mode='rb' closefd=True>
ResourceWarning: unclosed file <_io.BufferedReader name='/tmp/tmp4g2d4y05/tmp0v65u9_2'>

This PR fixes that.

@ahaldane
TST: fix io test that doesn't close file
70363b1 
Fix is to test_io_open_buffered_fromfile
@charris charris added this to the 1.13.0 release milestone Apr 26, 2017
@charris charris assigned charris and unassigned charris Apr 26, 2017
@charris charris self-requested a review April 26, 2017 17:18
@charris
Copy link
Member

charris commented Apr 26, 2017

LGTM.

@charris charris merged commit bab8ece into numpy:master Apr 26, 2017
@charris
Copy link
Member

charris commented Apr 26, 2017

Thanks Allan.

@ahaldane
Copy link
Member Author

Thanks Chuck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris approved these changes

Assignees
No one assigned
Labels
05 - Testing component: numpy._core
Projects
None yet
Milestone
1.13.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@ahaldane @charris