BUG: Make iscomplexobj compatible with custom dtypes again #8602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
reviewed
Feb 10, 2017
| @@ -268,6 +268,7 @@ def iscomplexobj(x): | |||
| """ | |||
| try: | |||
| dtype = x.dtype | |||
There was a problem hiding this comment.
How about instead making this type_ = x.dtype.type and reusing type_ below?
numpy/lib/type_check.py
Outdated
| @@ -268,6 +268,7 @@ def iscomplexobj(x): | |||
| """ | |||
| try: | |||
| dtype = x.dtype | |||
| getattr(dtype, "type") | |||
There was a problem hiding this comment.
This is no different from writing dtype.type
df41641 to
e3a9417
Compare
|
I have just force pushed a version reusing |
shoyer
approved these changes
Feb 10, 2017
|
Thanks! |
mhvk
reviewed
Feb 10, 2017
numpy/lib/type_check.py
Outdated
| try: | ||
| return issubclass(dtype.type, _nx.complexfloating) | ||
| return issubclass(type_, _nx.complexfloating) |
There was a problem hiding this comment.
This no longer needs to be inside a try/except to catch AttributeError
This change makes iscomplexobj compatible with custom array types using custom dtypes, that are not fully compatible to Numpys dtypes, which can nevertheless be coerced to a numpy array with asarray again, as has been the behaviour before PR numpy#7936. Fixes numpy#8601
e3a9417 to
bb1c471
Compare
|
Yes, of course. I just pushed a fixed version.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes iscomplexobj compatible with custom array types
using custom dtypes, that are not fully compatible to Numpys dtypes,
which can nevertheless be coerced to a numpy array with asarray
again, as has been the behaviour before PR #7936.
Fixes #8601