BUG: Fix iteration over reversed subspaces in mapiter_@name@. #8296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in numpy#8264, before this patch numpy crashes when the subspace of iterator has negative strides on the faster resetting branch for trivially iterable subspaces in mapiter_@name@. Noticing the offset between ptr and first item in subspace is constant, we calculate the offset from the first iteration and use it onwards. Fixes numpy#8264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8284.
As stated in #8264, before this patch numpy crashes when the
subspace of iterator has negative strides on the faster
resetting branch for trivially iterable subspaces in mapiter_@name@.
Noticing the offset between ptr and first item in subspace is
constant, we calculate the offset from the first iteration and use
it onwards.
Fixes #8264