Fix memory leak in reduction ufuncs #76
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dereferenced in the non-error case.
|
Looks good, I've applied it to both master and 1.6.x. |
fangerer
pushed a commit
to hpyproject/numpy-hpy
that referenced
this pull request
Dec 12, 2022
…few aborts Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from mq/GR-40169 to labs-hpy-port * commit '34f932dc6d969bfe269499190038cd5097683daa': address comments clean up clean up warnings add back PyDateTime_IMPORT Add back random import in numpy.__init__ fixing a bug Add few missing pieces couple of fixes and ports few more fixes many fixes and ports to HPy fix ref count bug fix a bug in np.array(..) and cause import numpy not to work port couple of function and remove few aborts
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vset_lane_s8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak in reduction ufuncs -- the error object was not being dereferenced in the non-error case.
To reproduce, run the following with valgrind:
import numpy as np x = np.ones((1000,)) for i in range(10): y = np.sum(x)