BUG: raise IEEE exception on AIX #16656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16505.
IEEE exception is not raised correctly on AIX 6.2, GCC 8.3, both 32 and 64 bits.
The PR correct this point to have the attempted behavior.
As an Example, see test
numpy/linalg/tests/test_linalg.py::TestMatrixPower::test_exceptions_not_invertible[dt10]
(output below).In
./numpy/core/src/npymath/ieee754.c.src
, AIX has a specific code to raise an exception. This code is not working correctly with GCC. With the general GCC code, the test passes.All other similar tests (all
TestMatrixPower::test_exceptions_not_invertible
andtest_generator_mt19937.py::TestRandomDist::test_multivariate_normal
) pass with this patch.No regression in test suite.
I cannot build Numpy with XLC, so I cannot confirm if the AIX specific code is useless for other compiler on AIX or not.