BUG: Fix aradixsort indirect indexing. #14417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
673d582 to
229dfd4
Compare
|
Let's make sure we fix this case too |
|
This fix fixes that case as well on my local machine. |
eric-wieser
reviewed
Sep 4, 2019
eric-wieser
reviewed
Sep 4, 2019
eric-wieser
reviewed
Sep 4, 2019
229dfd4 to
3a7cbaa
Compare
3a7cbaa to
003a3d4
Compare
eric-wieser
approved these changes
Sep 4, 2019
eric-wieser
reviewed
Sep 4, 2019
| @pytest.mark.parametrize('dtype',[ | ||
| np.uint8, np.uint16, np.uint32, np.uint64, | ||
| np.int8, np.int16, np.int32, np.int64, | ||
| np.float16, np.float32, np.float64 |
There was a problem hiding this comment.
Nice touch changing to the non-string names, thanks
|
Shippable has been hung up for about 8 hours, so merging without. Thanks Hameer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14413.