BUG: Fixes StopIteration error from 'np.genfromtext' for empty file with skip_header > 0 #14252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that enhancements need a release note. |
|
This strikes me as a bug fix - raising StopIteration outside of a |
|
Thanks @maxwell-aladago . |
Thank you too. It’s been a pleasure. I am a novice, and I want to be contributing as much as I can. I like how organised the NumPy library is, many open source projects don’t have such well organised code. Thanks for the awesome work you do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14225
Instead of throwing a
StopIterationerror whenskip_header > 0for an empty file, it returns aUserWarningand an empty list. This behaviour is consistent withskip_header=0,max_rows > 0andskip_rows > 0.