Skip to content

DOC: add backlinks to numpy.org #14235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2019
Merged

DOC: add backlinks to numpy.org #14235

merged 2 commits into from
Aug 11, 2019

Conversation

mattip
Copy link
Member

@mattip mattip commented Aug 8, 2019

Change the links in the blue boxes at the top of each page to numpy.org, numpy.org/doc and scipy.org.

Continuation of numpy/numpy.org#25 and gh-14073

@@ -121,7 +121,10 @@ def setup(app):
"edit_link": False,
"sidebar": "left",
"scipy_org_logo": False,
"rootlinks": []
"rootlinks": [("https://numpy.org/", "NumPy.org"),
("https://numpy.org/doc", "Docs"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps "Documentation" instead of "Docs"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. This is part of a "breadcrumb" design across the top of the page, and can get quite wide as is, see for instance an example page. I see I should put scipy.org first (or drop it altogether) to keep the breadcrumb order consistent. Let me know what you prefer:

  • docs vs documentation
  • scipy.org first or not at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parallel page on scipy.org uses Docs.

It also has a nice header, I wonder why the one from the front page is not used in the numpy/doc and numpy/devdoc pages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the example page helps. okay, let's stay with Docs.

It also has a nice header, I wonder why the one from the front page is not used in the numpy/doc and numpy/devdoc pages?

not sure

@mattip
Copy link
Member Author

mattip commented Aug 9, 2019

Added a header to the documentation pages in 0e26a52

@mattip mattip requested a review from rgommers August 11, 2019 08:24
@rgommers rgommers merged commit 67ecbcf into numpy:master Aug 11, 2019
@rgommers
Copy link
Member

okay merging this to keep things moving. let's see how it looks, thanks Matti!

@mattip
Copy link
Member Author

mattip commented Aug 11, 2019

hmm, the scipy.org link on the top looks out of place :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants