TST: Clean up of test_pocketfft.py #14200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relaxed test_fft_with_order for float32. Infinity norm round-off error of FFT is shown in G.U. Ramos, "Roundoff Error Analyss of the Fast Fourier Transform," Mathematics of Computation, vol. 25, no. 116, Oct. 1971, p. 757 to be bounded by sqrt(N)*K*eps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14178 .
Replaced
assert_array_almost_equalwithassert_allcloseseeing how the use of former is being discouraged.Fixed a likely typo:
raise ValueError->raise ValueError().Relaxed
test_fft_with_orderfor float32. Default tolerance ofassert_array_almost_equalwas not enough for results produced bymkl_fftin single precision, for example.The tolerance is now set to be proportional to
np.sqrt(X.size)*np.finfo(X.dtype).epsbased on the following paper.Infinity norm round-off error of FFT is shown in
G.U. Ramos, "Roundoff Error Analyss of the Fast Fourier Transform,"
Mathematics of Computation, vol. 25, no. 116, Oct. 1971, p. 757
to be bounded by sqrt(N)Keps.