BUG: Fix DeprecationWarning in python 3.8 #14143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to int Since `total_seconds` returns a python `float`, its easiest to convert to a C float and do the int conversion there Fixes numpygh-14077
charris
reviewed
Jul 28, 2019
| /* Rounding here is no worse than the integer division below. | ||
| * Only whole minute offsets are supported by numpy anyway. | ||
| */ | ||
| seconds_offset = (int)PyFloat_AsDouble(tmp); |
There was a problem hiding this comment.
OK, timezone offset in seconds should be safe in an int.
|
Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to implicit conversion of int. Since
total_secondsreturns a pythonfloat, its easiest to convert to a C float and do the int conversion thereFixes gh-14077