Skip to content

BUG: Fix file-like object check when saving arrays #14082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2019

Conversation

charris
Copy link
Member

@charris charris commented Jul 23, 2019

Backport of #14063 .

For writing arrays, only the write method is necessary.

I had code that was broken by this check and had to introduce a fake read method for it to work: https://github.com/luispedro/jug/blob/b32f4389acd1c3edf1a6a593799e853ded7849a2/jug/backends/encode.py#L88

@charris charris added this to the 1.17.0 release milestone Jul 23, 2019
@charris charris changed the title Backport 14063 BUG: Fix file-like object check when saving arrays Jul 23, 2019
@charris charris merged commit 91fbe4d into numpy:maintenance/1.17.x Jul 23, 2019
@charris charris deleted the backport-14063 branch July 23, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants