Skip to content

DOC: Prepare for 1.17.0rc1 release #13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2019
Merged

Conversation

charris
Copy link
Member

@charris charris commented Jun 29, 2019

Preliminary work preparing for the 1.17 release. Review of the release notes would be much appreciated. The changelog will be updated before release.

@charris charris added this to the 1.17.0 release milestone Jun 29, 2019
A new `numpy.ctypeslib.as_ctypes_type` function has been added, which can be
used to converts a `dtype` into a best-guess `ctypes` type. Thanks to this
used to converts a ``dtype`` into a best-guess ``ctypes`` type. Thanks to this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written before, doesn't ctypes become a sphinx link to the python docs? @mattip?

Ok with not linking dtype, that's pretty obvious to anyone who knows enough about numpy to read the release notes.

Copy link
Member Author

@charris charris Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also curious about the automatic linking, when it works and when it doesn't. IIRC NumPy links require the full numpy., but also seem to recall that that may have been fixed. Not sure how the links work for Python documentation. @mattip Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's normally a currentmodule set, and everything in that module and higher-level modules can be found. So say you're in linalg, then svd gets resolved, linspace as well, but randint needs to be referred to as random.randint. For release notes no currentmodule may be set, so then you'll need the full numpy.xxx. For Python the builtins should be resolved, anything in a stdlib module needs full import path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does a full python import path look like?

@@ -424,8 +456,8 @@ These ufuncs now call the ``__floor__``, ``__ceil__``, and ``__trunc__``
methods when called on object arrays, making them compatible with
`decimal.Decimal` and `fractions.Fraction` objects.

`quantile` now works on `fraction.Fraction` and `decimal.Decimal` objects
-------------------------------------------------------------------------
``quantile`` now works on ``fraction.Fraction`` and ``decimal.Decimal`` objects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before, did these not create links?

@charris charris changed the title WIP, DOC: Prepare for 1.17.0 release WIP, DOC: Prepare for 1.17.0rc1 release Jun 30, 2019
- Update mailmap.
- Edit release notes.
- Create changelog.

[ci skip]
@charris charris changed the title WIP, DOC: Prepare for 1.17.0rc1 release DOC: Prepare for 1.17.0rc1 release Jun 30, 2019
@charris
Copy link
Member Author

charris commented Jun 30, 2019

I'm going to put this in. The link questions need answering, but that can be done later.

@charris charris removed the 25 - WIP label Jun 30, 2019
@charris charris merged commit 27d77ce into numpy:master Jun 30, 2019
@charris charris deleted the prepare-1.17.0 branch May 2, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants