Skip to content

DOC: Specify range for numpy.angle #13374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2019
Merged

DOC: Specify range for numpy.angle #13374

merged 1 commit into from
Apr 20, 2019

Conversation

kritisingh1
Copy link
Member

Fixes #7426

@kritisingh1 kritisingh1 force-pushed the angle branch 2 times, most recently from 164be54 to bc6a4e6 Compare April 20, 2019 16:32
@eric-wieser
Copy link
Member

I think you should keep the word "counterclockwise" here

@kritisingh1
Copy link
Member Author

kritisingh1 commented Apr 20, 2019

When the angle is from (-pi, 0) it is a clockwise angle from the positive real axis. Should I specify the direction for both (-pi,0] and [0,pi] then? @eric-wieser

@eric-wieser
Copy link
Member

The direction of the numeric value is always counterclockwise. If angle returns -90°, it means -90° counterclockwise. Yes, this can also be expressed as a 90° angle clockwise, but that's irrelevant because it returns -90 not +90.

@mattip mattip merged commit 9050e0b into numpy:master Apr 20, 2019
@mattip
Copy link
Member

mattip commented Apr 20, 2019

Thanks @kritisingh1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy.angle shouldn't return negative values according to documentation?
3 participants