DOC: add more info to failure message #13293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
approved these changes
Apr 11, 2019
numpy/core/__init__.py
Outdated
| @@ -41,20 +41,12 @@ | |||
| except ImportError as exc: | |||
| import sys | |||
| msg = """ | |||
|
|
|||
| IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE! | |||
There was a problem hiding this comment.
Keeping this line gives us a nice filter for people who pasted the message without thinking, even if it is a little ugly. Happy to go either way on this
charris
approved these changes
Apr 13, 2019
|
LGTM. We might want to put a "when things go wrong" page somewhere listing common problems, maybe with links to the issues, but that is separate from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version information to the error message when import fails. Also shorten the message and de-emphasize build failures from a git checkout