STY: Fix weird indents to be multiples of 4 spaces #13169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally not a big fan of style-only fixes, they mess with history and make it hard to track where and why and in what context code was written. Are these really necessary? |
|
Better to have them in their own commit than to have an unrelated commit message touching these lines to fix them. Given that we mention the |
|
I think this is OK, it's not that big. My name is all over the history of some of these files because of the initial style fixes back around 1.3, not because I wrote the code. There is probably a style checker out there somewhere that we could adapt to keep these fixes to a minimum in the future. |
|
Thanks Eric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9705, plus a few greps to find other occurrences