Skip to content

DEV: remove _arg from public API, add matmul to benchmark ufuncs #12684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

mattip
Copy link
Member

@mattip mattip commented Jan 7, 2019

Fixes #12682 by removing the private _arg ufunc used for testing from the public API and adding matmul to the list of ufuncs in bench_ufuncs

@seberg
Copy link
Member

seberg commented Jan 7, 2019

Looks good, removal of _arg is definitely good. I wonder if we want gufunc in that benchmark, since it requires that the later matrices are aligned properly (which they currently are since they are squared), or whether we should just check for ufuncs with ufunc.signature is None.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@seberg
Copy link
Member

seberg commented Jan 9, 2019

OK, lets put this in. If we ever add ufuncs that cannot be tested together as a bunch here, we can still split it up into ufuncs and gufuncs.

@seberg seberg merged commit a4f1faa into numpy:master Jan 9, 2019
@seberg
Copy link
Member

seberg commented Jan 9, 2019

Are we still keeping commit messages starting with things? BENCH: is a bit nicer then.

@mattip mattip deleted the benchmark-ufuncs branch May 20, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants