DOC: fix some doctest failures #12560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjereddy
approved these changes
Dec 17, 2018
There was a problem hiding this comment.
This should be fine to merge then. If people feel passionately that refguide should fail on changing traceback error messages (I suspect it is only sensitive to the type of error), they could bring that up in the refguide wishlist issue.
Might have been nice to briefly indicate which docstring(s) are fixed in the commit message I suppose.
|
Thanks Matti. @tylerjereddy You should just go ahead and merge straight forward stuff like this. |
|
Marking this for backporting. See #13355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12483 by updating the docstring tests in matmul. Also tweak the exception message for other doctests