Skip to content

DEV: remove travis 32 bit job since it is running on azure #12539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

mattip
Copy link
Member

@mattip mattip commented Dec 13, 2018

We now have an Azure job to test linux 32 bit, let's remove the job it replaces from travis

@charris
Copy link
Member

charris commented Dec 13, 2018

@tylerjereddy Should we recommend docker rather than chroot for these types of tests?

@tylerjereddy
Copy link
Contributor

As far as I can tell both approaches (Docker and chroot) share the host kernel. It seems that Docker is likely providing somewhat better "isolation" from the host, so maybe reducing the likelihood of accidental 64-bit things polluting the build is a good justification for using Docker.

One suggestion for making the clean-up in this PR more comprehensive -- tools/travis-test.sh contains a bunch of code & comments for 32-bit chroot build. There's an entire setup_chroot() function that I suppose can likely be deleted now, and probably the logic that handles dispatch to that function as well.

@mattip
Copy link
Member Author

mattip commented Dec 13, 2018

removed chroot from travis-test.sh

Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- removes 60 lines of extraneous code / comments & I checked that Travis matrix is down to 11 entries from 12 on master.

@charris charris merged commit 7d92b06 into numpy:master Dec 13, 2018
@charris
Copy link
Member

charris commented Dec 13, 2018

Docker looks more portable and easier to maintain, so lets go with that for now. Thanks Matti.

@charris
Copy link
Member

charris commented Dec 13, 2018

Might be worth moving a few more things to azure. Travis gives us 5 parallel slots, so if we get down to <= 10 jobs we might save a couple or 5 minutes.

@charris
Copy link
Member

charris commented Dec 13, 2018

There are also some tests that that look like they could be consolidated.

@mattip mattip deleted the remove-travis-job branch May 20, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants