-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
TST: Added tests for np.tensordot() #12152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added test for np.tensordot() to test the function when there are no well defined axes present. Github issue #12130
I need some help with changing the documentation. |
numpy/core/tests/test_numeric.py
Outdated
@@ -2748,3 +2748,7 @@ def test_zero_dimension(self): | |||
td = np.tensordot(a, b, (1, 0)) | |||
assert_array_equal(td, np.dot(a, b)) | |||
assert_array_equal(td, np.einsum('ij,jk', a, b)) | |||
# Test resolution to issue #12130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be spelled simply "gh-12130"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to do it the gh-
way - the tests are littered with references to different historical issue trackers - it's always nice to know which issue tracker they were referring to, just in case we change again.
The documentation lives in |
Except this is not true, so let's not add that. |
@rishacha: Ping - mattip mentions above where to find the documentation. |
Fixed the comment and split this into a new test. If @rishacha wants to add docs, he can do so in another PR. |
Added test for np.tensordot() to test the function when there are no well defined axes present.
Ref: Github issue #12130