DOC: #defining -> #define / Added a short explanation for Numeric #11929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Sep 11, 2018
| #pragma message(_WARN___LOC__"Using deprecated NumPy API, disable it by " \ | ||
| "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION") | ||
| #pragma message(_WARN___LOC__"Using deprecated NumPy API, disable it with " \ | ||
| "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION") | ||
| #elif defined(__GNUC__) | ||
| #warning "Using deprecated NumPy API, disable it by " \ | ||
| "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" |
There was a problem hiding this comment.
Missed the message duplicate on this line
There was a problem hiding this comment.
I'm not sure what do you mean by "message duplicate". Anyway I found two more lines which used #defining instead of #define and fixed them the same way.
eric-wieser
reviewed
Sep 11, 2018
doc/release/1.7.0-notes.rst
Outdated
| ========================= | ||
| =========================== | ||
| NumPy 1.7.0 Release Notes | ||
| =========================== |
There was a problem hiding this comment.
Are you sure this doesn't break the rendering?
There was a problem hiding this comment.
I built the html file and it looks okay in my browser.
There was a problem hiding this comment.
I'd prefer this to stay as is - every other release note does not have these spaces. The bar for modifying past release notes should be fairly high, and I don't think these lines meet that
eric-wieser
approved these changes
Sep 11, 2018
jeffyancey
approved these changes
Sep 12, 2018
|
Thanks @derek-kim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial docs fix requests