Skip to content

DOC: add examples and extend existing dos for polynomial subclasses #11817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

jeffyancey
Copy link
Contributor

Documentation changes from #11811

@jeffyancey
Copy link
Contributor Author

@charris and @eric-wieser, should the pow fncs docstrings be modified to explicitly state that that array_like parameter must not be empty? Or should these functions be modified to support empty arrays?

Currently the polyutils.as_series() is used, which causes the follow error from line 176 if the array is empty:

ValueError: Coefficient array is empty

@eric-wieser
Copy link
Member

I don't think it needs to - if anything, I'd prefer to make polyutils.as_series work for empty arrays

@eric-wieser
Copy link
Member

Small typo in commit message, but I can fix it when I merge

@charris charris changed the title DOC: add examples and extend exisiting dos for polynomial subclasses DOC: add examples and extend existing dos for polynomial subclasses Aug 29, 2018
@charris charris merged commit febbe2a into numpy:master Aug 29, 2018
@charris
Copy link
Member

charris commented Aug 29, 2018

Thanks @jeffyancey .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants