-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
TST: Add Python 3.7 to CI testing #11598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Python 3.7 must run with sudo on xenial travis-ci/travis-ci#9069
Since we are already testing with 3.7-dev, I'm not convinced the travis issue still applies. Can you try simply removing the |
Did you read through the link in the commit message? 3.7 beta != 3.7 production release. |
Looks like you can also add it to |
@cclauss - thanks for noticing those issues with old ubuntu versions! This looks good to me. A question - probably best addressed separately - is whether we should be moving some of the other tests over to xenial as well. (There is also a possible optimization that we set in astropy but (apparently) not in numpy: |
travis-ci/travis-ci#9069 is still an OPEN issue because Precise and Trusty are still Travis CI's supported Linux versions so I would avoid moving to Xenial unless necessary (as it is with Py37). |
Please keep the 3.6 testing in |
@charris Ready for your review... Have I missed anything? |
doc/Makefile
Outdated
@@ -1,7 +1,7 @@ | |||
# Makefile for Sphinx documentation | |||
# | |||
|
|||
PYVER = 3.6 | |||
PYVER = 3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should not be changed, 3.6 is widespread these days, will probably be supported for a couple of years, and so using it to build the documentation makes sense. OTOH, 3.7 is brand new and not yet included in many distros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do we revert Circle CI to Py36?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do we revert Circle CI to Py36?
Hmm, to tell the truth, I don't know ;) Did you try it with only one of the two changed? It cannot hurt to stick with 3.6 for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CircleCI change without the Makefile change is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess it matters, good to know.
Thanks @cclauss . |
Add testing with Python 3.7 to both appveyor and travis.
TST: Add Python 3.7 to CI testing (#11598)
Add Python 3.7 to CI testing. Note that on travis-ci it must run with sudo on xenial, see travis-ci/travis-ci#9069.