Skip to content

TST: Show that histogramdd's normed argument is histogram's density #11373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

eric-wieser
Copy link
Member

Relevant to gh-4371

@charris
Copy link
Member

charris commented Jun 18, 2018

Thanks Eric. To bad we needed to replace normed with density for histogram

@eric-wieser
Copy link
Member Author

eric-wieser commented Jun 18, 2018

As a follow-up, I was planning to rename the argument to histogramdd from normed to density (deprecating the old name). (edit: done in gh-11531)

On the other hand, this just creates churn if we're also going to consider #9921 and come up with a different argument naming scheme (which I'm -0.5 on because I think people will choose a pmf when it's innapropriate if we make it too easy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants