BUG: Further back-compat fix for subclassed array repr #10674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10663
This special-cases 0d arrays so that, only for 0ds, we extract scalars using the ndarray
__getitem__
instead of any subclass's__getitem__
. In other words it reverts #10544 except for 0d arrays.This way we avoid the infinite recursion for subclassed-0d arrays that return 0ds instead of scalars when indexed, yet still pass subclassed-0d values on to the formatter functions when printing n-d array elements.
This PR does break two tests involving 0d-subclass-object arrays added in #10544, but those failed anyway in <1.13 and 1.14.0. That is,
sub([None, None])
prints assub([sub(None, dtype=object), sub(None, dtype=object)], dtype=object)
. I don't see a way of fixing those while not breaking the subclass-nd formatting behavior, which is more important.