Skip to content

[ENH]: Add CAT12 SANLM denoising filter #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Oct 18, 2021
Merged

[ENH]: Add CAT12 SANLM denoising filter #3374

merged 25 commits into from
Oct 18, 2021

Conversation

0rC0
Copy link
Contributor

@0rC0 0rC0 commented Sep 12, 2021 •
edited by effigies
Loading

Summary

Fixes #2783.

List of changes proposed in this PR (pull-request)

Acknowledgment

  • [X ] (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

effigies
effigies reviewed Sep 29, 2021
View reviewed changes
Copy link
Member

@effigies effigies left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Here's some quick comments. Please also apply black styling and run make specs.

@0rC0
Copy link
Contributor Author

0rC0 commented Sep 30, 2021 •
edited
Loading

Thank you for the review @effigies and sorry for the delay, I had a lot to work in the past days.

I'm going to work again on the PR next week!

BW

0rC0 and others added 16 commits October 5, 2021 20:55
@0rC0
Updated .zenodo.json
c690041
@0rC0
Updated .zenodo.json
15469d5
@0rC0 @effigies
Update nipype/interfaces/cat12/preprocess.py
57160c9 
default suffix removed

Co-authored-by: Chris Markiewicz <[email protected]>
@0rC0
Merge remote-tracking branch 'origin/cat12_sanlm' into cat12_sanlm
d0a8450
@0rC0 @effigies
Update nipype/interfaces/cat12/preprocess.py
94f6bf9 
Co-authored-by: Chris Markiewicz <[email protected]>
@0rC0
Merge remote-tracking branch 'origin/cat12_sanlm' into cat12_sanlm
585c8d5
@0rC0
rician as bool
5766e9d
@0rC0 @effigies
Update nipype/interfaces/cat12/preprocess.py
0b73002 
example filename

Co-authored-by: Chris Markiewicz <[email protected]>
@0rC0 @effigies
Update nipype/interfaces/cat12/preprocess.py
d737a20 
use fname_presuffix for output file

Co-authored-by: Chris Markiewicz <[email protected]>
@0rC0
Merge remote-tracking branch 'origin/cat12_sanlm' into cat12_sanlm
54400ef
@0rC0
style
1dedc71
@0rC0
non documented variable
aecdacd
@0rC0
run_black
6d7ba1d
@0rC0
fix
58974f6
@0rC0
black __init__.py
70f193f
@0rC0
example_skip
3e3ba87
@0rC0 0rC0 changed the title **[WIP]** [ENH]: Add CAT12 SANLM denoising filter [ENH]: Add CAT12 SANLM denoising filter Oct 10, 2021
effigies
effigies reviewed Oct 13, 2021
View reviewed changes
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was thinking for spm_type:

@effigies
Copy link
Member

Can you merge/rebase master to fix the tests? Also, you still need to run make specs.

@effigies effigies mentioned this pull request Oct 15, 2021
Merged
15 tasks
@effigies effigies merged commit 071e575 into nipy:master Oct 18, 2021
@0rC0
Copy link
Contributor Author

0rC0 commented Oct 18, 2021

Super! :-) and thanks for the help @effigies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CAT12 interface?
2 participants
@0rC0 @effigies