NGF: Update control data plane split telemetry #485
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update docs for CP/DP split telemetry changes.
Problem: Some small docs changes are needed for the new telemetry metrics/changes introduced with the control data plane split.
Solution: Add the new metrics. Also updated the data plane configuration document small error of including the
namespace
field in thegateway.infrastructure.parametersRef
field since that does not exist: https://gateway-api.sigs.k8s.io/reference/spec/#localparametersreference.Note: Left out GatewayAttachedNginxProxies in the document since I think it falls under the "we collect a count of NginxProxies"
Testing:
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩