Skip to content

NGINX Plus Release 34 #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 1, 2025
Merged

NGINX Plus Release 34 #343

merged 12 commits into from
Apr 1, 2025

Conversation

y82
Copy link
Contributor

@y82 y82 commented Apr 1, 2025

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@y82 y82 requested review from a team as code owners April 1, 2025 13:48
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) labels Apr 1, 2025
Copy link

github-actions bot commented Apr 1, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are minor. The one that worries me are the links to
https://nginx.org/en/docs/http/ngx_http_oidc_module.html, which is now a 404

Is there a separate PR that creates that page in the github.com/nginx/nginx repo?
(show me the PR or correct the links, and I'll approve)

Co-authored-by: Travis Martin <[email protected]>
Co-authored-by: Mike Jang <[email protected]>
@y82
Copy link
Contributor Author

y82 commented Apr 1, 2025

Most of my comments are minor. The one that worries me are the links to https://nginx.org/en/docs/http/ngx_http_oidc_module.html, which is now a 404

Is there a separate PR that creates that page in the github.com/nginx/nginx repo? (show me the PR or correct the links, and I'll approve)

it's nginx/nginx.org#141 (it's just merged and the links should be ok)

@y82 y82 requested review from mjang and travisamartin April 1, 2025 15:27
@y82 y82 requested a review from travisamartin April 1, 2025 15:32
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the URL that I was concerned about is now committed. All other issues I see are minor. So I'm approving based on our schedule requirements.

@y82 y82 requested a review from travisamartin April 1, 2025 16:29
@y82 y82 merged commit 9ce9274 into nginx:main Apr 1, 2025
5 of 6 checks passed
@route443
Copy link
Member

route443 commented Apr 1, 2025

I have hereby read the F5 CLA and agree to its terms

@y82 y82 deleted the r34 branch April 2, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants