-
Notifications
You must be signed in to change notification settings - Fork 102
NGINX Plus Release 34 #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of my comments are minor. The one that worries me are the links to
https://nginx.org/en/docs/http/ngx_http_oidc_module.html, which is now a 404
Is there a separate PR that creates that page in the github.com/nginx/nginx repo?
(show me the PR or correct the links, and I'll approve)
content/nginx/admin-guide/security-controls/configuring-oidc.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/security-controls/configuring-oidc.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/security-controls/configuring-oidc.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/security-controls/configuring-oidc.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/security-controls/configuring-oidc.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/active-directory-federation-services.md
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/active-directory-federation-services.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/active-directory-federation-services.md
Show resolved
Hide resolved
Co-authored-by: Mike Jang <[email protected]>
content/nginx/admin-guide/security-controls/configuring-oidc.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/security-controls/configuring-oidc.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Travis Martin <[email protected]> Co-authored-by: Mike Jang <[email protected]>
it's nginx/nginx.org#141 (it's just merged and the links should be ok) |
content/nginx/admin-guide/security-controls/configuring-oidc.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/security-controls/configuring-oidc.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Travis Martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the URL that I was concerned about is now committed. All other issues I see are minor. So I'm approving based on our schedule requirements.
content/nginx/deployment-guides/single-sign-on/active-directory-federation-services.md
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/active-directory-federation-services.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/oidc-njs/_index.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/oidc-njs/active-directory-federation-services.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/oidc-njs/auth0.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/oidc-njs/cognito.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/oidc-njs/keycloak.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/oidc-njs/okta.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/oidc-njs/onelogin.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/oidc-njs/ping-identity.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/single-sign-on/ping-identity.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Travis Martin <[email protected]>
I have hereby read the F5 CLA and agree to its terms |
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Give a brief overview of the problem or feature being addressed.
Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩