Fixes configuration logic for netty-4.1.16 module

[obenkenobi]

Overview

Fixes a bug in the internal netty config.

Expected behavior:

Setting this config to false (which is the default value) should resolve 'unknown' transactions in netty at the cost of less granularity when instrumenting HTTP2 web transactions.

  netty:
    http2:
      frame_read_listener:
        start_transaction: false

Setting the config to true causes the 'unknown' transactions to resurface but we get more granularity with HTTP2 transactions.

Description of the bug:

Setting the below config to false causes the 'unknown' transactions to appear again but setting it to true resolves it but HTTP2 is no longer supported.

  netty:
    http2:
      frame_read_listener:
        start_transaction: false

Solution:

One of the boolean values in the netty instrumentation was flipped. By switching that value, we resolve this issue.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.49%. Comparing base (5395d7c) to head (4e6e23c).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2355      +/-   ##
============================================
- Coverage     70.60%   70.49%   -0.12%     
+ Complexity    10220    10025     -195     
============================================
  Files           844      844              
  Lines         41179    40627     -552     
  Branches       6333     6160     -173     
============================================
- Hits          29075    28640     -435     
+ Misses         9285     9199      -86     
+ Partials       2819     2788      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.