-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor expression evaluator to use parser from actionlint package #908
Conversation
This comment has been minimized.
This comment has been minimized.
I think |
This comment has been minimized.
This comment has been minimized.
117fd22
to
f393daa
Compare
This comment has been minimized.
This comment has been minimized.
f393daa
to
49ce2fb
Compare
This comment has been minimized.
This comment has been minimized.
49ce2fb
to
58790da
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
439738e
to
f8cbc27
Compare
This comment has been minimized.
This comment has been minimized.
f8cbc27
to
ed96e72
Compare
This comment has been minimized.
This comment has been minimized.
ed96e72
to
f962084
Compare
This comment has been minimized.
This comment has been minimized.
f962084
to
67b9bed
Compare
This comment has been minimized.
This comment has been minimized.
67b9bed
to
4804a93
Compare
This comment has been minimized.
This comment has been minimized.
4804a93
to
5bec910
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
3aea593
to
035293c
Compare
This comment has been minimized.
This comment has been minimized.
Ah I got it, you forget to escape |
0e88659
to
68beb31
Compare
This comment has been minimized.
This comment has been minimized.
68beb31
to
c9beb89
Compare
@ZauberNerd this pull request has failed checks 🛠 |
@ZauberNerd @KnisterPeter |
@ZauberNerd this pull request has failed checks 🛠 |
@ChristopherHX I think something with inputs and secrets broke while rebasing against master and now Lines 39 to 56 in 686898e
Line 112 in 686898e
Since you made some changes there, do you have an immediate idea what I'm doing wrong? |
I'm debugging it carefully, there are expression evaluation errors in the log. Some values are empty. |
@ZauberNerd The inputs context is always available, also on workflowlevel see reusable workflows. |
Co-authored-by: Markus Wolf <[email protected]> Co-authored-by: Philipp Hinrichsen <[email protected]>
Co-authored-by: Markus Wolf <[email protected]> Co-authored-by: Philipp Hinrichsen <[email protected]>
The last open item (wrong implementation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that massive work, I tried to review whole PR carefully and so far it seems good to me
This is an early draft to showcase the general direction we're going with this change.We will of course rebase the commits, so that we can create separate PRs for the preparation-changes (refactoring of contexts, etc).Also there's still a few TODO comments that we have to resolve before this PR is ready to merge.Anyways, feedback is welcome :)Next steps:
toString
to be able to print all typesact
tests to pass with theexprparser
package